On Wed, Oct 31, 2012 at 10:28:08AM +0100, Steffen Trumtrar wrote: [...] > +/** > + * of_get_drm_display_mode - get a drm_display_mode from devicetree > + * @np: device_node with the timing specification > + * @dmode: will be set to the return value > + * @index: index into the list of display timings in devicetree > + * > + * DESCRIPTION:
I don't think this is necessary. > + * This function is expensive and should only be used, if only one mode is > to be > + * read from DT. To get multiple modes start with of_get_display_timing_list > ond You probably meant "and" at the end of this line. Also I'm not even sure that we should be exposing this function, but rather provide a helper which automatically adds the parsed modes to a DRM connector object. Thierry
pgpwDXDOB8ixu.pgp
Description: PGP signature
