Am 08.11.2012 21:46, schrieb Devin Heitmueller: > On Thu, Nov 8, 2012 at 1:37 PM, Frank Schäfer > <fschaefer....@googlemail.com> wrote: >> at least the "Silvercrest Webcam 1.3mpix" (board 71) exposes both >> endpoint types (0x82=isoc and 0x84=bulk). > Ah, interesting. It might be worthwhile to log a warning in dmesg if > the user sets the modprobe option but the board doesn't actually > expose any bulk endpoints. This might help avoid questions from users > (we already got one such question by somebody who believed enabling > this would put the device into bulk mode even though his hardware > didn't support it). > > Devin >
Well, I deliberately called the module 'prefer_bulk' (and not 'use_bulk', 'force_bulk' ...) which should imply that nothing is guaranteed. And selecting bulk transfers for a device which actually doesn not provide bulk support doesn't make sense and is clearly the users fault. Anway, I'm fine with adding a warning message and maybe I could extend the module parameter description, too. I'm going to wait for further feedback from Mauro before sending an updated version of the patch (series). Regards, Frank -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
