From: Wei Yongjun <yongjun_...@trendmicro.com.cn>

In case of error, the function vb2_dma_contig_init_ctx() returns
ERR_PTR() and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn>
---
 drivers/media/platform/davinci/vpbe_display.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/davinci/vpbe_display.c 
b/drivers/media/platform/davinci/vpbe_display.c
index 2bfde79..e181a52 100644
--- a/drivers/media/platform/davinci/vpbe_display.c
+++ b/drivers/media/platform/davinci/vpbe_display.c
@@ -1393,9 +1393,9 @@ static int vpbe_display_reqbufs(struct file *file, void 
*priv,
        }
        /* Initialize videobuf queue as per the buffer type */
        layer->alloc_ctx = vb2_dma_contig_init_ctx(vpbe_dev->pdev);
-       if (!layer->alloc_ctx) {
+       if (IS_ERR(layer->alloc_ctx)) {
                v4l2_err(&vpbe_dev->v4l2_dev, "Failed to get the context\n");
-               return -EINVAL;
+               return PTR_ERR(layer->alloc_ctx);
        }
        q = &layer->buffer_queue;
        memset(q, 0, sizeof(*q));

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to