Hi, On Fri, Dec 14, 2012 at 09:46:29AM -0800, Tony Lindgren wrote: > * Felipe Balbi <ba...@ti.com> [121214 09:36]: > > Hi, > > > > On Fri, Dec 14, 2012 at 09:28:09AM -0800, Tony Lindgren wrote: > > > * Tony Lindgren <t...@atomide.com> [121120 12:00]: > > > > Hi, > > > > > > > > * Timo Kokkonen <timo.t.kokko...@iki.fi> [121118 07:15]: > > > > > --- a/drivers/media/rc/ir-rx51.c > > > > > +++ b/drivers/media/rc/ir-rx51.c > > > > > @@ -74,6 +74,19 @@ static void lirc_rx51_off(struct lirc_rx51 > > > > > *lirc_rx51) > > > > > OMAP_TIMER_TRIGGER_NONE); > > > > > } > > > > > > > > > > +static void lirc_rx51_stop_tx(struct lirc_rx51 *lirc_rx51) > > > > > +{ > > > > > + if (lirc_rx51->wbuf_index < 0) > > > > > + return; > > > > > + > > > > > + lirc_rx51_off(lirc_rx51); > > > > > + lirc_rx51->wbuf_index = -1; > > > > > + omap_dm_timer_stop(lirc_rx51->pwm_timer); > > > > > + omap_dm_timer_stop(lirc_rx51->pulse_timer); > > > > > + omap_dm_timer_set_int_enable(lirc_rx51->pulse_timer, 0); > > > > > + wake_up(&lirc_rx51->wqueue); > > > > > +} > > > > > + > > > > > static int init_timing_params(struct lirc_rx51 *lirc_rx51) > > > > > { > > > > > u32 load, match; > > > > > > > > Good fixes in general.. But you won't be able to access the > > > > omap_dm_timer functions after we enable ARM multiplatform support > > > > for omap2+. That's for v3.9 probably right after v3.8-rc1. > > > > > > > > We need to find some Linux generic API to use hardware timers > > > > like this, so I've added Thomas Gleixner and linux-arm-kernel > > > > mailing list to cc. > > > > > > > > If no such API is available, then maybe we can export some of > > > > the omap_dm_timer functions if Thomas is OK with that. > > > > > > Just to update the status on this.. It seems that we'll be moving > > > parts of plat/dmtimer into a minimal include/linux/timer-omap.h > > > unless people have better ideas on what to do with custom > > > hardware timers for PWM etc. > > > > if it's really for PWM, shouldn't we be using drivers/pwm/ ?? > > > > Meaning that $SUBJECT would just request a PWM device and use it. That > > doesn't solve the whole problem, however, as pwm-omap.c would still need > > access to timer-omap.h. > > That would only help with omap_dm_timer_set_pwm() I think. > > The other functions are also needed by the clocksource and clockevent > drivers. And tidspbridge too:
well, we _do_ have drivers/clocksource ;-) -- balbi
signature.asc
Description: Digital signature