On 12 October 2012 00:11, David Härdeman <[email protected]> wrote:
> The RC_TYPE_* defines are currently used both where a single protocol is
> expected and where a bitmap of protocols is expected. This patch tries
> to separate the two in preparation for the following patches.
>
> The intended use is also clearer to anyone reading the code. Where a
> single protocol is expected, enum rc_type is used, where one or more
> protocol(s) are expected, something like u64 is used.
>
> The patch has been rewritten so that the format of the sysfs "protocols"
> file is no longer altered (at the loss of some detail). The file itself
> should probably be deprecated in the future though.
>
> I missed some drivers when creating the last version of the patch because
> some weren't enabled in my .config. This patch passes an allmodyes build.
>
> Signed-off-by: David Härdeman <[email protected]>
> ---

> @@ -38,7 +70,7 @@ struct rc_map {
>         unsigned int            size;   /* Max number of entries */
>         unsigned int            len;    /* Used number of entries */
>         unsigned int            alloc;  /* Size of *scan in bytes */
> -       u64                     rc_type;
> +       enum rc_type            rc_type;
>         const char              *name;
>         spinlock_t              lock;
>  };

But store_protocols() sets dev->rc_map.rc_type to a bitmap. Am I
missing something?

Cheers
James
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to