Hi Sachin,

Thank you for finding and correcting this.

Best wishes,
-- 
Kamil Debski
Linux Platform Group
Samsung Poland R&D Center


> -----Original Message-----
> From: Sachin Kamat [mailto:[email protected]]
> Sent: Wednesday, January 02, 2013 11:46 AM
> To: [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]
> Subject: [PATCH Resend] [media] s5p-mfc: Fix an error check
> 
> Checking unsigned variable for negative value always returns false.
> Hence make this value signed as we expect it to be negative too.
> 
> Fixes the following smatch warning:
> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c:572
> s5p_mfc_set_enc_ref_buffer_v6() warn: unsigned 'buf_size1' is never
> less than zero.
> 
> Signed-off-by: Sachin Kamat <[email protected]>

Acked-by: Kamil Debski <[email protected]>

> ---
> Added additional description in commit message.
> Please ignore the previous patch.
> ---
>  drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> index 5f9a5e0..91d5087 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
> @@ -535,8 +535,8 @@ void s5p_mfc_get_enc_frame_buffer_v6(struct
> s5p_mfc_ctx *ctx,  int s5p_mfc_set_enc_ref_buffer_v6(struct s5p_mfc_ctx
> *ctx)  {
>       struct s5p_mfc_dev *dev = ctx->dev;
> -     size_t buf_addr1, buf_size1;
> -     int i;
> +     size_t buf_addr1;
> +     int i, buf_size1;
> 
>       mfc_debug_enter();
> 
> --
> 1.7.4.1


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to