fimc_m2m_job_finish() has to be called with the m2m context for the necessary cleanup while resume. But currently fimc_m2m_job_finish() always passes fimc->m2m.ctx as NULL.
This patch changes the order of the calls for proper cleanup while resume. Signed-off-by: Shaik Ameer Basha <shaik.am...@samsung.com> --- drivers/media/platform/s5p-fimc/fimc-core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/s5p-fimc/fimc-core.c b/drivers/media/platform/s5p-fimc/fimc-core.c index 2a1558a..5b11544 100644 --- a/drivers/media/platform/s5p-fimc/fimc-core.c +++ b/drivers/media/platform/s5p-fimc/fimc-core.c @@ -868,14 +868,15 @@ static int fimc_m2m_resume(struct fimc_dev *fimc) { unsigned long flags; + if (test_and_clear_bit(ST_M2M_SUSPENDED, &fimc->state)) + fimc_m2m_job_finish(fimc->m2m.ctx, + VB2_BUF_STATE_ERROR); + spin_lock_irqsave(&fimc->slock, flags); /* Clear for full H/W setup in first run after resume */ fimc->m2m.ctx = NULL; spin_unlock_irqrestore(&fimc->slock, flags); - if (test_and_clear_bit(ST_M2M_SUSPENDED, &fimc->state)) - fimc_m2m_job_finish(fimc->m2m.ctx, - VB2_BUF_STATE_ERROR); return 0; } -- 1.8.0 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html