Hi, > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Saturday, January 19, 2013 6:43 PM > Hi Kamil, > > Thanks for the patch. > > On Mon, Jan 14, 2013 at 10:36:04AM +0100, Kamil Debski wrote: > > Set proper timestamp type in drivers that I am sure that use either > > MONOTONIC or COPY timestamps. Other drivers will correctly report > > UNKNOWN timestamp type instead of assuming that all drivers use > > monotonic timestamps. > > What other kind of timestamps there can be? All drivers (at least those > not > mem-to-mem) that do obtain timestamps using system clock use monotonic > ones.
Not set. It is not a COPY or MONOTONIC either. Any new or custom kind of timestamp, maybe? > I'd think that there should no longer be any drivers using the UNKNOWN > timestamp type: UNKNOWN is either from monotonic or realtime clock, and > we just replaced all of them with the monotonic ones. No driver uses > realtime timestamps anymore. Maybe there should be no drivers using UNKNOWN. But definitely there should be no driver reporting MONOTONIC when the timestamp is not monotonic. > How about making MONOTONIC timestamps default instead, or at least > assigning all drivers something else than UNKNOWN? So why did you add the UNKNOWN flag? The way I see it - UNKNOWN is the default and the one who coded the driver will set it to either MONOTONIC or COPY if it is one of these two. It won't be changed otherwise. There are drivers, which do not fill the timestamp field at all: - drivers/media/platform/coda.c - drivers/media/platform/exynos-gsc/gsc-m2m.c - drivers/media/platform/m2m-deinterlace.c - drivers/media/platform/mx2_emmaprp.c - drivers/media/platform/s5p-fimc/fimc-m2m.c - drivers/media/platform/s5p-g2d.c - drivers/media/platform/s5p-jpeg/jpeg-core.c The way you did it in your patches left no room for any kind of choice. I did comment at least twice about mem-2-mem devices in your RFCs, if I remember correctly. I think Sylwester was also writing about this. Still everything got marked as MONOTONIC. If we were to assume that there were no other timestamp types then monotonic (which is not true, but this was your assumption), then what was the reason to add this timestamp framework? Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
