On Tue March 19 2013 00:20:00 Laurent Pinchart wrote:
> Hi Hans,
>
> Thanks for the patch.
>
> On Monday 18 March 2013 15:12:03 Hans Verkuil wrote:
> > From: Hans Verkuil <hans.verk...@cisco.com>
> >
> > This ioctl is defined as IOW, so pass the argument as const.
> >
> > Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
> > Acked-by: Guennadi Liakhovetski <g.liakhovet...@gmx.de>
> > Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com>
>
> [snip]
>
> > diff --git a/drivers/media/pci/ivtv/ivtv-ioctl.c
> > b/drivers/media/pci/ivtv/ivtv-ioctl.c index 080f179..15e08aa 100644
> > --- a/drivers/media/pci/ivtv/ivtv-ioctl.c
> > +++ b/drivers/media/pci/ivtv/ivtv-ioctl.c
> > @@ -711,49 +711,50 @@ static int ivtv_g_chip_ident(struct file *file, void
> > *fh, struct v4l2_dbg_chip_i }
> >
> > #ifdef CONFIG_VIDEO_ADV_DEBUG
> > -static int ivtv_itvc(struct ivtv *itv, unsigned int cmd, void *arg)
> > +static volatile u8 __iomem *ivtv_itvc_start(struct ivtv *itv,
> > + const struct v4l2_dbg_register *regs)
>
> I haven't changed my mind since v1, I still don't think you need a volatile
> here :-)
I agree with you, but changing this requires changing things not just in this
function but also in a header. Basically, it just adds noise to this patch.
This patch is about making s_register const and I don't want to mix it with
other changes unless absolutely necessary.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
