On 03/21/2013 11:54 PM, Mauro Carvalho Chehab wrote:
Em Sun, 10 Mar 2013 04:03:03 +0200
Antti Palosaari <[email protected]> escreveu:
  static struct ite_config af9035_it913x_config = {
-       .chip_ver = 0x01,
+       .chip_ver = 0x02,

@@ -1153,6 +1161,7 @@ static int af9035_tuner_attach(struct dvb_usb_adapter 
*adap)
        case AF9033_TUNER_IT9135_38:
        case AF9033_TUNER_IT9135_51:
        case AF9033_TUNER_IT9135_52:
+               af9035_it913x_config.chip_ver = 0x01;

Hmmm... aren't you missing a break here? If not, please add a comment, as
otherwise reviewers think that this is a bug.

It is correct as it was set 0x02 by init. And variable was removed totally few patches later.


regards
Antti

--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to