Hi Jon, On Mon, Apr 29, 2013 at 10:41:06PM +0200, Jon Arne Jørgensen wrote: > This is the second version of a patch-set previously posted by Mauro, > the first verseon was posted on 26 April, and can be found here: > http://www.spinics.net/lists/linux-media/msg63079.html > > The purpose of this patch is to add support for the gm7113c chip in the > saa7115 driver. > The gm7113c chip is a chinese clone of the Philips/NXP saa7113 chip. > The chip is found in several cheap usb video capture devices. > > drivers/media/i2c/saa7115.c | 207 > +++++++++++++++++++++++++++++----------- > include/media/v4l2-chip-ident.h | 2 + > 2 files changed, 155 insertions(+), 54 deletions(-) >
Good work! Just some minor comments about the way the patchset has been submitted. First of all, this is a very ackward cover letter patch (cover letter is the zero-index patch). I think you will find easier to use git-format-patch command like this (just an example): # Create a three-patch patchset: $ git format-patch -3 --cover-letter --subject "PATCH v2" -o my-v2-patchset -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
