On Monday, July 29, 2013 12:34:24 PM Joe Perches wrote: > On Mon, 2013-07-29 at 13:59 +0200, Rafael J. Wysocki wrote: > > On Sunday, July 28, 2013 10:29:04 PM Joe Perches wrote: > > > It's convenient to have ethernet mac addresses use > > > ETH_ALEN to be able to grep for them a bit easier and > > > also to ensure that the addresses are __aligned(2). > [] > > > diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h > [] > > > @@ -44,6 +44,8 @@ > [] > > > +#include <linux/if_ether.h> > > > + > [] > > > @@ -605,7 +607,7 @@ struct acpi_ibft_nic { > [] > > > - u8 mac_address[6]; > > > + u8 mac_address[ETH_ALEN]; > > > Please don't touch this file. > > > > It comes from a code base outside of the kernel and should be kept in sync > > with > > the upstream. > > Which files in include/acpi have this characteristic?
Generally, all whose names start with "ac" except for acpi_bus.h, acpi_drivers.h and acpi_numa.h. > Perhaps an include/acpi/README is appropriate. Yes, we can add one. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html