Hello, Mauro, Hans,

On 14.12.2013 18:15, Antti Palosaari wrote:
Use own format ops for SDR data:
vidioc_enum_fmt_sdr_cap
vidioc_g_fmt_sdr_cap
vidioc_s_fmt_sdr_cap
vidioc_try_fmt_sdr_cap

To be honest, I am a little bit against that patch. Is there any good reason we duplicate these FMT ops every-time when new stream format is added? For my eyes that is mostly just bloating the code without good reason.

regards
Antti



Cc: Hans Verkuil <hverk...@xs4all.nl>
Signed-off-by: Antti Palosaari <cr...@iki.fi>
---
  drivers/media/v4l2-core/v4l2-dev.c   |  8 ++++----
  drivers/media/v4l2-core/v4l2-ioctl.c | 18 +++++++++---------
  include/media/v4l2-ioctl.h           |  8 ++++++++
  3 files changed, 21 insertions(+), 13 deletions(-)

diff --git a/drivers/media/v4l2-core/v4l2-dev.c 
b/drivers/media/v4l2-core/v4l2-dev.c
index 9f15e25..a84f4ea 100644
--- a/drivers/media/v4l2-core/v4l2-dev.c
+++ b/drivers/media/v4l2-core/v4l2-dev.c
@@ -673,13 +673,13 @@ static void determine_valid_ioctls(struct video_device 
*vdev)
                SET_VALID_IOCTL(ops, VIDIOC_G_SLICED_VBI_CAP, 
vidioc_g_sliced_vbi_cap);
        } else if (is_sdr) {
                /* SDR specific ioctls */
-               if (ops->vidioc_enum_fmt_vid_cap)
+               if (ops->vidioc_enum_fmt_sdr_cap)
                        set_bit(_IOC_NR(VIDIOC_ENUM_FMT), valid_ioctls);
-               if (ops->vidioc_g_fmt_vid_cap)
+               if (ops->vidioc_g_fmt_sdr_cap)
                        set_bit(_IOC_NR(VIDIOC_G_FMT), valid_ioctls);
-               if (ops->vidioc_s_fmt_vid_cap)
+               if (ops->vidioc_s_fmt_sdr_cap)
                        set_bit(_IOC_NR(VIDIOC_S_FMT), valid_ioctls);
-               if (ops->vidioc_try_fmt_vid_cap)
+               if (ops->vidioc_try_fmt_sdr_cap)
                        set_bit(_IOC_NR(VIDIOC_TRY_FMT), valid_ioctls);

                if (is_rx) {
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c 
b/drivers/media/v4l2-core/v4l2-ioctl.c
index a7e6b52..18aa36a 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -939,7 +939,7 @@ static int check_fmt(struct file *file, enum v4l2_buf_type 
type)
                        return 0;
                break;
        case V4L2_BUF_TYPE_SDR_CAPTURE:
-               if (is_sdr && is_rx && ops->vidioc_g_fmt_vid_cap)
+               if (is_sdr && is_rx && ops->vidioc_g_fmt_sdr_cap)
                        return 0;
                break;
        default:
@@ -1062,9 +1062,9 @@ static int v4l_enum_fmt(const struct v4l2_ioctl_ops *ops,
                        break;
                return ops->vidioc_enum_fmt_vid_out_mplane(file, fh, arg);
        case V4L2_BUF_TYPE_SDR_CAPTURE:
-               if (unlikely(!is_rx || !ops->vidioc_enum_fmt_vid_cap))
+               if (unlikely(!is_rx || !ops->vidioc_enum_fmt_sdr_cap))
                        break;
-               return ops->vidioc_enum_fmt_vid_cap(file, fh, arg);
+               return ops->vidioc_enum_fmt_sdr_cap(file, fh, arg);
        }
        return -EINVAL;
  }
@@ -1121,9 +1121,9 @@ static int v4l_g_fmt(const struct v4l2_ioctl_ops *ops,
                        break;
                return ops->vidioc_g_fmt_sliced_vbi_out(file, fh, arg);
        case V4L2_BUF_TYPE_SDR_CAPTURE:
-               if (unlikely(!is_rx || !is_sdr || !ops->vidioc_g_fmt_vid_cap))
+               if (unlikely(!is_rx || !is_sdr || !ops->vidioc_g_fmt_sdr_cap))
                        break;
-               return ops->vidioc_g_fmt_vid_cap(file, fh, arg);
+               return ops->vidioc_g_fmt_sdr_cap(file, fh, arg);
        }
        return -EINVAL;
  }
@@ -1190,10 +1190,10 @@ static int v4l_s_fmt(const struct v4l2_ioctl_ops *ops,
                CLEAR_AFTER_FIELD(p, fmt.sliced);
                return ops->vidioc_s_fmt_sliced_vbi_out(file, fh, arg);
        case V4L2_BUF_TYPE_SDR_CAPTURE:
-               if (unlikely(!is_rx || !is_sdr || !ops->vidioc_s_fmt_vid_cap))
+               if (unlikely(!is_rx || !is_sdr || !ops->vidioc_s_fmt_sdr_cap))
                        break;
                CLEAR_AFTER_FIELD(p, fmt.sdr);
-               return ops->vidioc_s_fmt_vid_cap(file, fh, arg);
+               return ops->vidioc_s_fmt_sdr_cap(file, fh, arg);
        }
        return -EINVAL;
  }
@@ -1260,10 +1260,10 @@ static int v4l_try_fmt(const struct v4l2_ioctl_ops *ops,
                CLEAR_AFTER_FIELD(p, fmt.sliced);
                return ops->vidioc_try_fmt_sliced_vbi_out(file, fh, arg);
        case V4L2_BUF_TYPE_SDR_CAPTURE:
-               if (unlikely(!is_rx || !is_sdr || !ops->vidioc_try_fmt_vid_cap))
+               if (unlikely(!is_rx || !is_sdr || !ops->vidioc_try_fmt_sdr_cap))
                        break;
                CLEAR_AFTER_FIELD(p, fmt.sdr);
-               return ops->vidioc_try_fmt_vid_cap(file, fh, arg);
+               return ops->vidioc_try_fmt_sdr_cap(file, fh, arg);
        }
        return -EINVAL;
  }
diff --git a/include/media/v4l2-ioctl.h b/include/media/v4l2-ioctl.h
index e0b74a4..8be32f5 100644
--- a/include/media/v4l2-ioctl.h
+++ b/include/media/v4l2-ioctl.h
@@ -40,6 +40,8 @@ struct v4l2_ioctl_ops {
                                              struct v4l2_fmtdesc *f);
        int (*vidioc_enum_fmt_vid_out_mplane)(struct file *file, void *fh,
                                              struct v4l2_fmtdesc *f);
+       int (*vidioc_enum_fmt_sdr_cap)     (struct file *file, void *fh,
+                                           struct v4l2_fmtdesc *f);

        /* VIDIOC_G_FMT handlers */
        int (*vidioc_g_fmt_vid_cap)    (struct file *file, void *fh,
@@ -62,6 +64,8 @@ struct v4l2_ioctl_ops {
                                           struct v4l2_format *f);
        int (*vidioc_g_fmt_vid_out_mplane)(struct file *file, void *fh,
                                           struct v4l2_format *f);
+       int (*vidioc_g_fmt_sdr_cap)    (struct file *file, void *fh,
+                                       struct v4l2_format *f);

        /* VIDIOC_S_FMT handlers */
        int (*vidioc_s_fmt_vid_cap)    (struct file *file, void *fh,
@@ -84,6 +88,8 @@ struct v4l2_ioctl_ops {
                                           struct v4l2_format *f);
        int (*vidioc_s_fmt_vid_out_mplane)(struct file *file, void *fh,
                                           struct v4l2_format *f);
+       int (*vidioc_s_fmt_sdr_cap)    (struct file *file, void *fh,
+                                       struct v4l2_format *f);

        /* VIDIOC_TRY_FMT handlers */
        int (*vidioc_try_fmt_vid_cap)    (struct file *file, void *fh,
@@ -106,6 +112,8 @@ struct v4l2_ioctl_ops {
                                             struct v4l2_format *f);
        int (*vidioc_try_fmt_vid_out_mplane)(struct file *file, void *fh,
                                             struct v4l2_format *f);
+       int (*vidioc_try_fmt_sdr_cap)    (struct file *file, void *fh,
+                                         struct v4l2_format *f);

        /* Buffer handlers */
        int (*vidioc_reqbufs) (struct file *file, void *fh, struct 
v4l2_requestbuffers *b);



--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to