Commit e63b009d6e "" changed the error codes i2c ACK errors from -ENODEV to 
-ENXIO.
But it also introduced a line that maps -ENXIO back to -ENODEV in case of empty 
i2c
messages, which makes no sense, because
1.) an ACK error is an ACK error no matter what the i2c message content is
2.) -ENXIO is perfectly suited for probing, too
3.) we are loosing the ability to distinguish USB device disconnects

Signed-off-by: Frank Schäfer <fschaefer....@googlemail.com>
---
 drivers/media/usb/em28xx/em28xx-i2c.c |    1 -
 1 Datei geändert, 1 Zeile entfernt(-)

diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c 
b/drivers/media/usb/em28xx/em28xx-i2c.c
index ba6433c..a26d7d4 100644
--- a/drivers/media/usb/em28xx/em28xx-i2c.c
+++ b/drivers/media/usb/em28xx/em28xx-i2c.c
@@ -539,7 +539,6 @@ static int em28xx_i2c_xfer(struct i2c_adapter *i2c_adap,
                                if (rc == -ENXIO) {
                                        if (i2c_debug > 1)
                                                printk(KERN_CONT " no 
device\n");
-                                       rc = -ENODEV;
                                } else {
                                        if (i2c_debug > 1)
                                                printk(KERN_CONT " ERROR: 
%i\n", rc);
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to