From: Hans Verkuil <hans.verk...@cisco.com>

This function never checked if width and height are correct. Add such
a check so the v4l2-compliance tool returns OK again for vivi.

Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
---
 drivers/media/platform/vivi.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/vivi.c b/drivers/media/platform/vivi.c
index 643937b..7360a84 100644
--- a/drivers/media/platform/vivi.c
+++ b/drivers/media/platform/vivi.c
@@ -1121,7 +1121,11 @@ static int vidioc_enum_frameintervals(struct file *file, 
void *priv,
        if (!fmt)
                return -EINVAL;
 
-       /* regarding width & height - we support any */
+       /* check for valid width/height */
+       if (fival->width < 48 || fival->width > MAX_WIDTH || (fival->width & 3))
+               return -EINVAL;
+       if (fival->height < 32 || fival->height > MAX_HEIGHT)
+               return -EINVAL;
 
        fival->type = V4L2_FRMIVAL_TYPE_CONTINUOUS;
 
-- 
1.9.rc1

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to