The read mode register bits 8 and 9 are set and marked as reserved.
Don't clear them.

Signed-off-by: Philipp Zabel <p.za...@pengutronix.de>
---
 drivers/media/i2c/mt9v032.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c
index 33a110a..052e754 100644
--- a/drivers/media/i2c/mt9v032.c
+++ b/drivers/media/i2c/mt9v032.c
@@ -415,6 +415,7 @@ static int mt9v032_s_stream(struct v4l2_subdev *subdev, int 
enable)
        struct i2c_client *client = v4l2_get_subdevdata(subdev);
        struct mt9v032 *mt9v032 = to_mt9v032(subdev);
        struct v4l2_rect *crop = &mt9v032->crop;
+       unsigned int read_mode;
        unsigned int hbin;
        unsigned int vbin;
        int ret;
@@ -425,9 +426,11 @@ static int mt9v032_s_stream(struct v4l2_subdev *subdev, 
int enable)
        /* Configure the window size and row/column bin */
        hbin = fls(mt9v032->hratio) - 1;
        vbin = fls(mt9v032->vratio) - 1;
-       ret = mt9v032_write(client, MT9V032_READ_MODE,
-                           hbin << MT9V032_READ_MODE_COLUMN_BIN_SHIFT |
-                           vbin << MT9V032_READ_MODE_ROW_BIN_SHIFT);
+       read_mode = mt9v032_read(client, MT9V032_READ_MODE);
+       read_mode &= ~0xff; /* bits 0x300 are reserved */
+       read_mode |= hbin << MT9V032_READ_MODE_COLUMN_BIN_SHIFT |
+                    vbin << MT9V032_READ_MODE_ROW_BIN_SHIFT;
+       ret = mt9v032_write(client, MT9V032_READ_MODE, read_mode);
        if (ret < 0)
                return ret;
 
-- 
2.0.0.rc2

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to