On 07/07/14 18:32, Jacek Anaszewski wrote:
> JPEG IP on Exynos3250 SoC requires enabling two clock
> gates for its operation. This patch documents this
> requirement.
> 
> Signed-off-by: Jacek Anaszewski <j.anaszew...@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com>
> Cc: Rob Herring <robh...@kernel.org>
> Cc: Pawel Moll <pawel.m...@arm.com>
> Cc: Mark Rutland <mark.rutl...@arm.com>
> Cc: Ian Campbell <ijc+devicet...@hellion.org.uk>
> Cc: Kumar Gala <ga...@codeaurora.org>
> Cc: devicet...@vger.kernel.org
> ---
>  .../bindings/media/exynos-jpeg-codec.txt           |    9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt 
> b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
> index 937b755..20cd150 100644
> --- a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
> +++ b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt
> @@ -3,9 +3,12 @@ Samsung S5P/EXYNOS SoC series JPEG codec
>  Required properties:
>  
>  - compatible : should be one of:
> -               "samsung,s5pv210-jpeg", "samsung,exynos4210-jpeg";
> +               "samsung,s5pv210-jpeg", "samsung,exynos4210-jpeg",
> +               "samsung,exynos3250-jpeg";
>  - reg                : address and length of the JPEG codec IP register set;
>  - interrupts : specifies the JPEG codec IP interrupt;
>  - clocks     : should contain the JPEG codec IP gate clock specifier, from 
> the
> -               common clock bindings;
> -- clock-names        : should contain "jpeg" entry.
> +               common clock bindings; for Exynos3250 SoC special clock gate
> +               should be defined as the second element of the clocks array

Entries in the clocks and clock-names can be in any order, the only
requirement normally is that they match. I would rephrase this to
something along the lines of:

 - clocks : should contain the JPEG codec IP gate clock specifier and
            for the Exynos3250 SoC additionally the SCLK_JPEG entry; from the
            common clock bindings;

> +- clock-names        : should contain "jpeg" entry and additionally 
> "sclk-jpeg" entry
> +               for Exynos3250 SoC

--
Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to