on avr32 arch, those warnings happen:
        drivers/media/firewire/firedtv-fw.c: In function 'node_update':
        drivers/media/firewire/firedtv-fw.c:329: warning: comparison is always 
true due to limited range of data type

In this particular case, the signal is desired, as the isochannel
var can be initalized with -1 inside the driver.

So, change the type to s8, to avoid issues on archs where char
is unsigned.

Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com>

diff --git a/drivers/media/firewire/firedtv.h b/drivers/media/firewire/firedtv.h
index c2ba085e0d20..346a85be6de2 100644
--- a/drivers/media/firewire/firedtv.h
+++ b/drivers/media/firewire/firedtv.h
@@ -96,7 +96,7 @@ struct firedtv {
 
        enum model_type         type;
        char                    subunit;
-       char                    isochannel;
+       s8                      isochannel;
        struct fdtv_ir_context  *ir_context;
 
        fe_sec_voltage_t        voltage;
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to