On 2015年01月02日 00:51, Mauro Carvalho Chehab wrote: > /* > @@ -416,6 +418,11 @@ struct dvb_frontend { > struct dvb_frontend_ops ops; > struct dvb_adapter *dvb; > struct i2c_client *fe_cl; > +#if defined(CONFIG_MEDIA_CONTROLLER) > + struct media_device *mdev; > + struct media_entity demod_entity; > +#endif > +
I understood that this patch was invalidated by the updated patch series: "dvb core: add basic suuport for the media controller", and now the demod_entity is registered in dvbdev.c::dvb_register_device() via dvb_frontend_register(). Is that right? And if so, Shouldn't only the (tuner) subdevices be registered separately in dvb_i2c_attach_tuner(), instead of dvb_i2c_attach_fe()? (and it would be simpler if "mdev" can be accessed like dvb_fe_get_mdev() {return fepriv->dvbdev->mdev;}, instead of having a cached value in dvb_frontend.) sorry if I'm totally wrong, I don't have an experience with media controller API. regards, akihiro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html