Terve, On Wed, Jul 29, 2015 at 06:29:05PM +0300, Antti Palosaari wrote: > commit ce0eff016f7272faa6dc6eec722b1ca1970ff9aa > [media] vb2: allow requeuing buffers while streaming > > That commit causes buf_queue() called on infinity loop when > start_streaming() returns error. On that case resources are eaten > quickly and machine crashes. > > Cc: Hans Verkuil <hverk...@xs4all.nl> > Signed-off-by: Antti Palosaari <cr...@iki.fi>
Fixed by this patch in media-fixes: commit 6d058c5643e16779ae4c001d2e893c140940e48f Author: Sakari Ailus <sakari.ai...@linux.intel.com> Date: Fri Jul 3 04:37:07 2015 -0300 [media] vb2: Only requeue buffers immediately once streaming is started Buffers can be returned back to videobuf2 in driver's streamon handler. In this case vb2_buffer_done() with buffer state VB2_BUF_STATE_QUEUED will cause the driver's buf_queue vb2 operation to be called, queueing the same buffer again only to be returned to videobuf2 using vb2_buffer_done() and so on. Add a new buffer state VB2_BUF_STATE_REQUEUEING which, when used as the state argument to vb2_buffer_done(), will result in buffers queued to the driver. Using VB2_BUF_STATE_QUEUED will leave the buffer to videobuf2, as it was before "[media] vb2: allow requeuing buffers while streaming". Fixes: ce0eff016f72 ("[media] vb2: allow requeuing buffers while streaming") [mche...@osg.samsung.com: fix warning: enumeration value 'VB2_BUF_STATE_REQUEUEING' not handled in switch] Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> Cc: sta...@vger.kernel.org # for v4.1 Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> -- Terveisin, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html