On Saturday 18 June 2016 17:22:59 Pavel Machek wrote:
> > +/*
> > + *
> > + * Stingray sensor mode settings for Scooby
> > + *
> > + *
> > + */
>
> I'd fix it to normal comment style... and possibly remove it. Can you
> understand what it says?
>
> > + },
> > + .regs = {
> > + { ET8EK8_REG_8BIT, 0x1239, 0x4F }, /* */
> > + { ET8EK8_REG_8BIT, 0x1238, 0x02 }, /* */
> > + { ET8EK8_REG_8BIT, 0x123B, 0x70 }, /* */
> > + { ET8EK8_REG_8BIT, 0x123A, 0x05 }, /* */
> > + { ET8EK8_REG_8BIT, 0x121B, 0x63 }, /* */
> > + { ET8EK8_REG_8BIT, 0x1220, 0x85 }, /* */
> > + { ET8EK8_REG_8BIT, 0x1221, 0x00 }, /* */
> > + { ET8EK8_REG_8BIT, 0x1222, 0x58 }, /* */
> > + { ET8EK8_REG_8BIT, 0x1223, 0x00 }, /* */
> > + { ET8EK8_REG_8BIT, 0x121D, 0x63 }, /* */
> > + { ET8EK8_REG_8BIT, 0x125D, 0x83 }, /* */
> > + { ET8EK8_REG_TERM, 0, 0}
> > + }
>
> I'd remove the empty comments...
>
> > +struct et8ek8_meta_reglist meta_reglist = {
> > + .version = "V14 03-June-2008",
>
> Do we need the version?
>
> > + .reglist = {
> > + { .ptr = &mode1_poweron_mode2_16vga_2592x1968_12_07fps },
> > + { .ptr = &mode1_16vga_2592x1968_13_12fps_dpcm10_8 },
> > + { .ptr = &mode3_4vga_1296x984_29_99fps_dpcm10_8 },
> > + { .ptr = &mode4_svga_864x656_29_88fps },
> > + { .ptr = &mode5_vga_648x492_29_93fps },
> > + { .ptr = &mode2_16vga_2592x1968_3_99fps },
> > + { .ptr = &mode_648x492_5fps },
> > + { .ptr = &mode3_4vga_1296x984_5fps },
> > + { .ptr = &mode_4vga_1296x984_25fps_dpcm10_8 },
> > + { .ptr = 0 }
> > + }
> > +};
>
> I'd say .ptr = NULL.
> Anyway, this code was generated from configuration ini files and perl script available from: https://gitorious.org/omap3camera/camera-firmware Originally in Maemo above C structure is compiled into binary file and via request_firmware() loaded from userspace to kernel driver. For me this sounds like a big overkill, so I included above reglist code direcly into et8ek8 kernel driver to avoid request_firmware() and separate userspace storage... And for smia-sensor (front webcam) in that gitorious repository is also reglist structure. It is not needed? Can somebody investigate why it is not needed? -- Pali Rohár pali.ro...@gmail.com
signature.asc
Description: This is a digitally signed message part.
