On Tue, 09 Feb 2010 15:29:22 -0500
Nicolas Pitre <n...@fluxnic.net> wrote:

> +     BUG_ON(!func);
> +     BUG_ON(!func->card);
> +
> +     host = func->card->host;

It's a bit redundant to check for null and then deref the pointer - the
kernel will reliably oops on the NULL deref, which gives us the same
info.

I guess the BUG_ON is more useful in the case where a double-deref is
being performed, as it can otherwise be a bit hard to work out which
pointer was NULL.

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to