Marek Szyprowski wrote: > > This patch increases the timeout value on sdhci-s3c controller by using > SDHCI_QUIRK_BROKEN_TIMEOUT_VAL quirk. Without it most transfers from > external mmc cards fails on Samsung s5pv210 SoCs based systems. Tested > on Samsung Aquila board. >
Hi, Seems to use max timeout value, 0xE. However, should be use SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK. Because basically, Samsung MMC used sdclock as timeout clock. Please refer to below URL: http://article.gmane.org/gmane.linux.kernel.mmc/304 And new patch with SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK will be submitted. > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com> > --- > drivers/mmc/host/sdhci-s3c.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c > index ad30f07..2b6cb44 100644 > --- a/drivers/mmc/host/sdhci-s3c.c > +++ b/drivers/mmc/host/sdhci-s3c.c > @@ -331,6 +331,7 @@ static int __devinit sdhci_s3c_probe(struct platform_device > *pdev) > * transfers, not sure if this is a problem with this specific > * SDHCI block, or a missing configuration that needs to be set. */ > host->quirks |= SDHCI_QUIRK_NO_BUSY_IRQ; > + host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL; > > host->quirks |= (SDHCI_QUIRK_32BIT_DMA_ADDR | > SDHCI_QUIRK_32BIT_DMA_SIZE); > -- Thanks. Best regards, Kgene. -- Kukjin Kim <kgene....@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
