On Sun, Aug 29, 2010 at 1:24 AM, Chris Ball <c...@laptop.org> wrote:
> Hi Kyungmin,
>
>   > It's already patched. you can find it easily at list.
>
> I think you're talking about this patch from Zhangfei:
>
> From: Zhangfei Gao <zg...@marvell.com>
> Date: Mon, 16 Aug 2010 21:15:32 -0400
> Subject: [PATCH] sdhci: support MMC_CAP_MMC_HIGHSPEED
>
> Signed-off-by: Zhangfei Gao <zg...@marvell.com>
> Acked-by: Matt Fleming <m...@console-pimps.org>
> Acked-by: Kyungmin Park <kmp...@infradead.org>
> ---
>  drivers/mmc/host/sdhci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 7855121..913555e 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1823,7 +1823,7 @@ int sdhci_add_host(struct sdhci_host *host)
>                mmc->caps |= MMC_CAP_4_BIT_DATA;
>
>        if (caps & SDHCI_CAN_DO_HISPD)
> -               mmc->caps |= MMC_CAP_SD_HIGHSPEED;
> +               mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
>
>        if (host->quirks & SDHCI_QUIRK_BROKEN_CARD_DETECTION)
>                mmc->caps |= MMC_CAP_NEEDS_POLL;
> --

right, it's required patch and should be merged at this rc window.

>
> But this patch wasn't sent to Andrew either -- and so isn't in Linus'
> or Andrew's tree -- and it's also only one of the two hunks in George's
> earlier patch.  George also had:
>
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1180,7 +1180,8 @@ static void sdhci_set_ios(struct mmc_host *mmc, struct 
> mmc_ios *ios)
>        else
>                ctrl &= ~SDHCI_CTRL_4BITBUS;
>
> -       if (ios->timing == MMC_TIMING_SD_HS &&
> +       if ((ios->timing == MMC_TIMING_SD_HS ||
> +            ios->timing == MMC_TIMING_MMC_HS) &&
>            !(host->quirks & SDHCI_QUIRK_NO_HISPD_BIT))
>                ctrl |= SDHCI_CTRL_HISPD;
>        else
>
Does it need? I mean when probing the mmc card it doesn't have
MMC_TIMING_MMC_HS. so it can't trigger the this condition at my
environment.

> So, we still have to send a patch to Andrew, and decide which patch it
> should be.  What do you think?

Anyone okay.
>
> Thanks,
>
> - Chris.
> --
> Chris Ball   <c...@laptop.org>   <http://printf.net/>
> One Laptop Per Child
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to