> static int mmc_pad_resources(struct sdhci_host *sdhci)
> {
>         if (!devm_stm_pad_claim(sdhci->mmc->parent,
>                                 &stx7108_mmc_pad_config,
>                                 dev_name(sdhci->mmc->parent)))
>                 return -ENODEV;
> 
>         return 0;
> }
> 
> static struct sdhci_pltfm_data stx7108_mmc_platform_data = {
>                 .init = &mmc_pad_resources,

You can drop the &

>                 .quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
> };
> 
> static struct platform_device stx7108_mmc_device = {
>                 .name = "sdhci",
> 
> [snip]

All in all, this looks like the right way! A good example how to
slightly update and then use the pltfm-driver. Redundant code saved and
benefits for all added :)

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature

Reply via email to