On Sun, Sep 26, 2010 at 10:45:02PM +0800, Haojian Zhuang wrote: > > I prefer we rename it to something like sdhci-mmp.c and the 'pxa' in the > > source code to 'mmp' to cause less confusion with pxamci.c? > > Maybe sdhci-pxa.c is better. pxamci.c isn't compatible with sdhci, so > it won't make people confusion.
The confusion can still happen when people are wondering which driver to build for their SoC. It seems that both names are confusing -- sdhci-mmp would confuse this driver with the one submitted by Saeed Bishara for Dove/MMP, and sdhci-pxa confuses it with pxamci.c. Have you considered sdhci-mmp for Saeed's driver, and sdhci-mmp2 for this driver? Or, sdhci-dove and sdhci-mmp2? Perhaps a non-exhaustive distinction is better than an incorrectly generalized one. Thanks, -- Chris Ball <c...@laptop.org> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
