Kishore, 

<<snip>>

A minor comment

> +int twl6030_mmc_card_detect(struct device *dev, int slot)
> +{
> +     int ret = -EIO;
> +     u8 read_reg = 0;
> +     struct platform_device *pdev = to_platform_device(dev);
> +
> +     if (pdev->id) {
> +             /* TWL6030 provide's Card detect support for
> +              * only MMC1 controller.
> +              */

Check multiline comment style

> +             pr_err("Unkown MMC controller %d in %s\n", 
> pdev->id, __func__);
> +             return ret;
> +     }
> +     /*
> +      * BIT0 of MMC_CTRL on TWL6030 provides card status for MMC1
> +      * 0 - Card not present ,1 - Card present
> +      */
> +     ret = twl_i2c_read_u8(TWL6030_MODULE_ID0, &read_reg,
> +                                             TWL6030_MMCCTRL);
> +     if (ret >= 0)
> +             ret = read_reg & STS_MMC;
> +     return ret;
> +}
> +EXPORT_SYMBOL(twl6030_mmc_card_detect);
> +

<<snip>>--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to