On Wed, 29 Dec 2010, Ohad Ben-Cohen wrote: > On Tue, Dec 28, 2010 at 11:46 PM, Alan Stern <[email protected]> > wrote: > > Similarly, during system suspend mmc_suspend_host() should be > > responsible for doing all the necessary power-down operations. Runtime > > PM is completely out of the picture at this time. And this should be > > independent of mac80211 -- in fact, the card should be powered down > > appropriately even if the kernel doesn't have a mac80211 layer. > > And it is. > > But in order to boot the firmware on resume, we need to reset the > device. And if system suspend has been cancelled before > mmc_power_off() was invoked, we will not be able to. So, in this case > too, the driver will have to power the device off.
If the suspend transition was cancelled before mmc_power_off(), why do you need to boot the firmware on resume? Since the device hasn't actually been powered off, can't it continue using the same firmware as before? What routine is responsible for deciding to boot the firmware, and what is its call path? > It all really boils down to the same solution - we will always have to > bypass runtime PM and directly control the power of the device. While this is probably true, I'm not at all convinced that the current design is layered correctly. Fixing the design might reduce the amount of bypassing required. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
