Hi, > linux-mmc@ folks, any strong opinions on this driver? My impression is > that it looks reasonable, but has some areas of being pretty far from > standard CodingStyle.
I totally agree (sadly it is hard to review because of its size) and I am still not convinced of the sysfs-entry. Then again, it is a working driver. > I'm leaning towards merging it as-is and then > working on incremental fixes; please yell if that sounds like a bad idea. What about staging? From my all overall impression, the driver would fit there. Also, there are more people lurking around fixing coding-style than here. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
