Hi, On Mon, Apr 25 2011, Philip Rakity wrote: > A quirk does not seem to the right way to go since there is now 2 points of > failure > > a) The quirk can be defined and host->ops->get_shared_pins may not be. > > how about > > if (host->ops->get_shared_pins) > host->ops->get_shared_pins(host)
Yep, I agree with Philip -- even if you use a quirk, you should test a function pointer before calling it. I also agree that you don't need a quirk here because this isn't a modification to SDHCI spec behavior, it's just a hook into platform code. Thanks, - Chris. -- Chris Ball <c...@laptop.org> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
