> > > The issue was initially found by Eric Benard as below. > > > > > > http://permalink.gmane.org/gmane.linux.ports.arm.kernel/108031 > > > > > > Not sure about other SDHCI based controller, but on Freescale eSDHC, > > > the SDHCI_INT_CARD_INSERT bits will be immediately set again when it > > > gets cleared, if a card is inserted. The driver need to mask the irq > > > to prevent interrupt storm which will freeze the system. And the > > > SDHCI_INT_CARD_REMOVE gets the same situation. > > > > > > The patch fixes the problem based on the initial idea from > > > Eric Benard. > > > > > > Signed-off-by: Shawn Guo <shawn....@linaro.org> > > > Cc: Eric Benard <e...@eukrea.com> > > > > Hmm, that should get enough testing on non-imx (and even non-ARM) > > devices. And a comment describing the situation. > > > Agreed. Will add something in commit message to mention the > situation. That's why I hope we can get the patch on mmc-next at
I actually meant a comment in the code, so it will be obvious for later hackers why the "extra" steps are in there... -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
