On Tue, Jun 28, 2011 at 10:52 PM, Paul Walmsley <p...@pwsan.com> wrote: > (cc'ing Adrian also) > > Hi Balaji > > On Wed, 22 Jun 2011, Balaji T K wrote: > >> Use runtime autosuspend APIs to enable auto suspend delay > > Does this really need to use runtime autosuspend? Seems to me that since > PM runtime is just controlling the MMC IP blocks and not the regulators in > this instance, this could simply use pm_runtime_put*() and just avoid the > extra power wastage and complexity involved in autosuspend. >
I have seen some instabilities if delay is very less, on some production boards. The previous implementation used 100ms delay before disabling the clocks. Is there any specific issue I should be aware of, for using _autosuspend ? > Besides, the correct autosuspend timeout seems use-case dependent. > > By the way, if possible, it would be really good if you could update this > patch series soon to address the comments. If these MMC driver changes > can be ready to merge for 3.1, then we also have a chance of > integrating some hwmod cleanup patches that depend on this driver's PM > runtime conversion. > > Just noticed your mail after I posted my patches.. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
