Hi Heiko, On Wed, Dec 07, 2011 at 11:52:23, Heiko Schocher wrote: > Hello Sekhar, > > here the forwarded comment from Ido Yariv to my patch. I tried > with current kernel MMC Controller 2 on my am1808 based board > without my fix, and it works fine, so no need for applying my > patch. > > Thanks > bye, > Heiko > > here the message from Ido: > > Betreff: Re: [PATCH] arm, da8xx, mmc: set second MMC controllers default queue > Datum: Mon, 5 Dec 2011 10:35:10 +0200 > Von: Ido Yariv <i...@wizery.com> > An: h...@denx.de > CC: juha.kui...@gmail.com
I think Ido replied to only you and Juha, that's why even I am not able to see his reply on the list. > Referenzen: <1322991210-20486-1-git-send-email...@denx.de> > <20111204102741.GL32400@WorkStation> <4edc7c00.30...@denx.de> > > Hi Heiko, > > On Dec 5, 2011 10:08 AM, "Heiko Schocher" <h...@denx.de> wro > > Ok ... patch not longer needed, but isn't it better to setup here > > immediately the right values? If so, I can sent a v2 with your > > suggested comment change. > > These are just default values which will get overwritten later on, so im > not sure if it matters much. I guess it wouldn't hurt to use default_queue > instead of queue 1. > It would have helped if you posted the complete message here but I figured this out. I assume that Ido's explanation is as below: EDMA channel is allocated in MMC driver through the call to edma_alloc_channel() api and the last argument passed to this api is the event queue number. Currently the event queue number being passed is EVENTQ_DEFAULT. Inside edma_alloc_channel() there is a call to map_dmach_queue() which also takes event queue number as argument. map_dmach_queue() function initializes the event queue number to default_queue (being passed from platform data), if it is EVENTQ_DEFAULT. I wanted to know why MMC/SD was not working initially for you even with this piece of code? > In any case, if you do chose to submit v2, the commit message should also > be changed if it doesnt really fix anything. I would still say, your patch is the clean way of addressing the issue. May be you can modify the commit message as Ido has pointed out. Sekhar, do you have any comments? Thanks, Sudhakar -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
