> -----Original Message-----
> From: Chris Ball [mailto:c...@laptop.org]
> Sent: Wednesday, December 14, 2011 2:06 AM
> To: Philip Rakity
> Cc: Huang Changming-R66093; linux-mmc@vger.kernel.org; Huang Changming-
> R66093
> Subject: Re: [PATCH 1/4] SDHCI: add sdhci_get_cd callback to detect the
> card
> 
> Hi,
> 
> On Mon, Dec 05 2011, Philip Rakity wrote:
> >> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> >> index 6d8eea3..66afd82 100644
> >> --- a/drivers/mmc/host/sdhci.c
> >> +++ b/drivers/mmc/host/sdhci.c
> >> @@ -2,6 +2,7 @@
> >>  * linux/drivers/mmc/host/sdhci.c - Secure Digital Host Controller
> >> Interface driver
> >>  *
> >>  *  Copyright (C) 2005-2008 Pierre Ossman, All Rights Reserved.
> >> + *  Copyright (C) 2011 Freescale Semiconductor Inc.
> >
> >
> > Lots of folks have made mods to this code and they have not added a
> > copyright name.
> > What is the rule Chris ?
> 
> You're right that many people have added far more significant changes
> than this without adding a copyright string, so we shouldn't add this one
> now.
> 
> In general, though, I'd say that the rule is that you may (but are not
> required to) add a copyright string if your change is reasonably large
> and non-obvious/non-boilerplate.  I don't think the copyright string
> means anything -- copyright is implicit in the authorship history which
> Git preserves -- but I'm not a lawyer.  Having your name in the copyright
> string may make enforcing the GPL for that driver slightly easier for you,
> so for that reason I'm glad Pierre added himself.
> 
According to my company policy, for the open source changes, I can't add myself 
to the copyright.
If you think it is not reasonable to add the copyright, I will remove it in 
next version.

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to