Hi,

On Tue, Jun 05 2012, Philip Rakity wrote:
> On Jun 5, 2012, at 7:11 PM, Mark F. Brown wrote:
>
>> Hi Philip,
>> 
>> Minor nitpicks: You should reuse SDHCI_QUIRK_MISSING_CAPS rather than
>> adding SDHCI_QUIRK2_MISSING_CAPS2. The less quirks the better IMHO.
>
> I am not sure that this is a good idea.  It breaks the existing code
> for people using quirks
> for capability register 1.

But it doesn't seem likely that someone would have a missing caps1
register and not have a missing caps2 register, right?  (Probably
the current users of the quirk aren't even on SD 3.0 devices, else
someone would have yelled about this already.)

So I think we could give the quirk reuse a try and see what happens.

Thanks,

- Chris.
-- 
Chris Ball   <c...@laptop.org>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to