Hi, On Fri, Jun 29 2012, Aaron Lu wrote: > Add a new flag of SDHCI_NEEDS_RETUNING_TIMER to represent if the host > currently needs retuning timer when driving the card inserted.
Minor changes: Could we call it "SDHCI_USING_RETUNING_TIMER", then? I don't think NEEDS makes the use clear enough. > @@ -1889,10 +1891,9 @@ out: > * try tuning again at a later time, when the re-tuning timer expires. > * So for these controllers, we return 0. Since there might be other > * controllers who do not have this capability, we return error for > - * them. > + * them. SDHCI_NEEDS_RETUNING_TIMER means the host supports re-tuning. This comment seems wrong, or at least incomplete. You've just described in the commit message how the flag's not about whether the host supports it, but is instead about whether it's currently in use by the card. Thanks, - Chris. -- Chris Ball <c...@laptop.org> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
