On 17/09/2013 11:57, Jiri Prchal :
This patch adds pinctrl to soc dtsi file.

Signed-off-by: Jiri Prchal <jiri.prc...@aksignal.cz>


Jiri,

I will rework your patch by splitting the two lines. This will allow us to be consistent with other AT91 SoC/boards Device Tree descriptions.

+               pinctrl-names = "default";

This one is going in the SoC file, like you did.

+               pinctrl-0 = <&pinctrl_mmc0_slot0_clk_cmd_dat0>;

This one is under the responsibility of the board itself. The reason behind this is that the dat0 line can be multiplexed on another pin.

So, if you need a particular pinctrl configuration on the board side, please send another patch for this addition.

Thanks bye,


---
  arch/arm/boot/dts/at91sam9x5.dtsi |    2 ++
  1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi 
b/arch/arm/boot/dts/at91sam9x5.dtsi
index cf78ac0..c5d26b0 100644
--- a/arch/arm/boot/dts/at91sam9x5.dtsi
+++ b/arch/arm/boot/dts/at91sam9x5.dtsi
@@ -556,6 +556,8 @@
                                interrupts = <12 IRQ_TYPE_LEVEL_HIGH 0>;
                                dmas = <&dma0 1 AT91_DMA_CFG_PER_ID(0)>;
                                dma-names = "rxtx";
+                               pinctrl-names = "default";
+                               pinctrl-0 = <&pinctrl_mmc0_slot0_clk_cmd_dat0>;
                                #address-cells = <1>;
                                #size-cells = <0>;
                                status = "disabled";



--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to