On Wed, Sep 25, 2013 at 7:37 PM, Chris Ball <c...@laptop.org> wrote: > Hi, > > On Wed, Sep 25 2013, Chris Ball wrote: >> Hi, >> >> On Fri, Sep 20 2013, Ulf Hansson wrote: >>> On 19 September 2013 19:20, Grant Grundler <grund...@chromium.org> wrote: >>>> struct mmc_queue defines issue_fn as an indirect function call. >>>> issue_fn field only gets set to mmc_blk_issue_rq and only gets >>>> invoked immediately after calling blk_fetch_request(). >>>> Don't bother with indirect function call - it's pointless and just >>>> obfuscates the code. >>>> >>>> Signed-off-by: Grant Grundler <grund...@chromium.org> >>> >>> Acked-by: Ulf Hansson <ulf.hans...@linaro.org> >> >> Thanks, pushed to mmc-next for 3.13. > > Have dropped this, it's breaking my build: > > /home/cjb/git/mmc/drivers/mmc/card/block.c:1955:12: warning: > ‘mmc_blk_issue_rq’ defined but not used [-Wunused-function]
The function is declared static. :( Let me respin to remove the static and add a function prototype to a header file. I just got lucky when I built this in an earlier tree. sorry about that... grant > /home/cjb/git/mmc/drivers/mmc/card/queue.c: In function ‘mmc_queue_thread’: > /home/cjb/git/mmc/drivers/mmc/card/queue.c:70:4: error: implicit declaration > of function ‘mmc_blk_issue_rq’ [-Werror=implicit-function-declaration] > > Grant, please could you take a look and resubmit? > > - Chris. > -- > Chris Ball <c...@laptop.org> <http://printf.net/> -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
