On 22/01/14 17:00, Ulf Hansson wrote: > Hosts supporting MMC_CAP_WAIT_WHILE_BUSY shall not be waiting for busy > detection completion in the recovery path, which were the case when > using R1B response. > > Start using R1 as response instead to align behavior, no matter if > MMC_CAP_WAIT_WHILE_BUSY is supported or not.
This does not make sense to me. If you are sending a STOP command you should use the correct response type. R1B should be OK here because the card should release the busy signal in any case except failure. > > Signed-off-by: Ulf Hansson <ulf.hans...@linaro.org> > --- > drivers/mmc/card/block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c > index 87cd2b0..74169fa 100644 > --- a/drivers/mmc/card/block.c > +++ b/drivers/mmc/card/block.c > @@ -728,7 +728,7 @@ static int send_stop(struct mmc_card *card, u32 *status) > int err; > > cmd.opcode = MMC_STOP_TRANSMISSION; > - cmd.flags = MMC_RSP_SPI_R1B | MMC_RSP_R1B | MMC_CMD_AC; > + cmd.flags = MMC_RSP_SPI_R1 | MMC_RSP_R1 | MMC_CMD_AC; > err = mmc_wait_for_cmd(card->host, &cmd, 5); > if (err == 0) > *status = cmd.resp[0]; > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
