Hi Seungwon, On 18 April 2014 15:36, Seungwon Jeon <tgih....@samsung.com> wrote: > This series contains the change for selection of bus speed mode. > Previous implementation is complicated and some sequence is duplicated. > And specially, HS400 mode eMMC5.0 is introduced this time. > This patch-set has been tested in Exynos SoC. > > Note: > This patch-set depends on "[PATCH RESEND v3 1/7] mmc: clarify DDR timing mode > between SD-UHS and eMMC". > > Changes in v6: > (6/6) Included "mmc: core: add DT bindings for eMMC HS400 1.8/1.2V" > into this patch-set > (5/6) Changed return type of prepare_hs400_tuning callback(int -> > void)
I would favour the int return type, that leaves room for the possibility of drivers to fail. Moreover, I have already sent a pull request to Chris, with the v5 version of this patchset, which I think is fine. Kind regards Uffe > Changes in v5: > (5/5) Added callback operation for HS400 target operation frequency > instead of specific timing identifier. > (2/5) Removed using union declaration. > > Changes in v4: > (5/5)Reverting to HS mode is included in mmc_select_hs400() using > __mmc_switch(). > > Changes in v3: > Removed the function to check DDR type(mmc_snoop_ddr). > Rebased with the latest branch. > > Seungwon Jeon (6): > mmc: drop the speed mode of card's state > mmc: identify available device type to select > mmc: step power class after final selection of bus mode > mmc: rework selection of bus speed mode > mmc: add support for HS400 mode of eMMC5.0 > mmc: add DT bindings for eMMC HS400 1.8/1.2V > > Documentation/devicetree/bindings/mmc/mmc.txt | 2 + > drivers/mmc/core/bus.c | 9 +- > drivers/mmc/core/core.c | 3 +- > drivers/mmc/core/debugfs.c | 5 +- > drivers/mmc/core/host.c | 4 + > drivers/mmc/core/mmc.c | 666 > +++++++++++++++---------- > drivers/mmc/core/sd.c | 16 +- > drivers/mmc/core/sd.h | 1 - > drivers/mmc/core/sdio.c | 8 +- > include/linux/mmc/card.h | 27 +- > include/linux/mmc/host.h | 43 ++- > include/linux/mmc/mmc.h | 23 +- > 12 files changed, 486 insertions(+), 321 deletions(-) > > Thanks, > sw-j > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
