Hello, On Monday 11 May 2015 13:15:17 Nicholas Krause wrote: > This adds a pointer cast to long in the function, sh_mmif_request_dma_one
I would use the uintptr_t type instead of long, as it has been designed for this purpose exactly. > for the when assigning one of the variables slave_id_tx or slave_id_rx of > the structure pointer,pdata to the void pointer, slave_data and the enum > directon respectfully. It's very nice to be respectful, but the commit message doesn't tell why this is needed. Something along the lines of "Cast integer to void * through uintptr_t to avoid compiler warning when compiling on 64bit platforms." would be more helpful. > Signed-off-by: Nicholas Krause <xerofo...@gmail.com> > --- > drivers/mmc/host/sh_mmcif.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c > index 7eff087..e276558 100644 > --- a/drivers/mmc/host/sh_mmcif.c > +++ b/drivers/mmc/host/sh_mmcif.c > @@ -398,8 +398,8 @@ sh_mmcif_request_dma_one(struct sh_mmcif_host *host, > > if (pdata) > slave_data = direction == DMA_MEM_TO_DEV ? > - (void *)pdata->slave_id_tx : > - (void *)pdata->slave_id_rx; > + (void *)(long)pdata->slave_id_tx : > + (void *)(long)pdata->slave_id_rx; > > chan = dma_request_slave_channel_compat(mask, shdma_chan_filter, > slave_data, &host->pd->dev, -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
