On 17 September 2015 at 15:09, Tobias Klauser <tklau...@distanz.ch> wrote:
> Use of_property_read_u32 instead of of_get_property with return value
> checks and endianness conversion.
>
> Signed-off-by: Tobias Klauser <tklau...@distanz.ch>

Thanks, applied for next!

Kind regards
Uffe

> ---
> v2:
>   - Directly use plfrm_host->clock in the call to of_property_read_u32(), as
>     suggested by Ulf Hansson.
>
>  drivers/mmc/host/sdhci-pltfm.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
> index a207f5a..87fb5ea 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -71,9 +71,7 @@ void sdhci_get_of_property(struct platform_device *pdev)
>         struct device_node *np = pdev->dev.of_node;
>         struct sdhci_host *host = platform_get_drvdata(pdev);
>         struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> -       const __be32 *clk;
>         u32 bus_width;
> -       int size;
>
>         if (of_get_property(np, "sdhci,auto-cmd12", NULL))
>                 host->quirks |= SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12;
> @@ -101,9 +99,7 @@ void sdhci_get_of_property(struct platform_device *pdev)
>             of_device_is_compatible(np, "fsl,mpc8536-esdhc"))
>                 host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>
> -       clk = of_get_property(np, "clock-frequency", &size);
> -       if (clk && size == sizeof(*clk) && *clk)
> -               pltfm_host->clock = be32_to_cpup(clk);
> +       of_property_read_u32(np, "clock-frequency", &pltfm_host->clock);
>
>         if (of_find_property(np, "keep-power-in-suspend", NULL))
>                 host->mmc->pm_caps |= MMC_PM_KEEP_POWER;
> --
> 2.5.0
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to