Hi List, I just found that there are some minor issues in kmod iternal list implementation implemented by libkmod-list.c.
Say
1. list_node_append() is identical with list_node_insert_before(),
so somehow the list_node_append() in fact does "prepend" operation.
2. just the same as list_node_append(), kmod_list_append() which
invokes the former just do "prepend" operation rather than "append".
I'd like to fix these internal APIs to do the operation suggested by its
name like
1. drop list_node_append()
2. call list_node_insert_after() to do "append" operation
3. call list_mode_insert_before() to do "prepend" operation
Since the list here is circular linked, so I think these changes should
not break things except the test cases.
Any comments are appreciated.
--
Thanks,
Chengwei
signature.asc
Description: Digital signature
