On Thu, Feb 22, 2024 at 2:00 AM Alice Ryhl <[email protected]> wrote:
>
> On Wed, Feb 21, 2024 at 8:41 PM Suren Baghdasaryan <[email protected]> wrote:
> >
> > From: Kent Overstreet <[email protected]>
> >
> > Memory allocation profiling is turning krealloc() into a nontrivial
> > macro - so for now, we need a helper for it.
> >
> > Until we have proper support on the rust side for memory allocation
> > profiling this does mean that all Rust allocations will be accounted to
> > the helper.
> >
> > Signed-off-by: Kent Overstreet <[email protected]>
> > Cc: Miguel Ojeda <[email protected]>
> > Cc: Alex Gaynor <[email protected]>
> > Cc: Wedson Almeida Filho <[email protected]>
> > Cc: Boqun Feng <[email protected]>
> > Cc: Gary Guo <[email protected]>
> > Cc: "Björn Roy Baron" <[email protected]>
> > Cc: Benno Lossin <[email protected]>
> > Cc: Andreas Hindborg <[email protected]>
> > Cc: Alice Ryhl <[email protected]>
> > Cc: [email protected]
> > Signed-off-by: Suren Baghdasaryan <[email protected]>
>
> Currently, the Rust build doesn't work throughout the entire series
> since there are some commits where krealloc is missing before you
> introduce the helper. If you introduce the helper first before
> krealloc stops being an exported function, then the Rust build should
> work throughout the entire series. (Having both the helper and the
> exported function at the same time is not a problem.)

Ack. I'll move it up in the series.

>
> With the patch reordered:
>
> Reviewed-by: Alice Ryhl <[email protected]>

Thanks Alice!

>
> Alice

Reply via email to