Hello!

> This defensiveness is understandable, but why would you be called if your tbusy
> is 1? I'd almost be tempted to put in a panic() if that happens, since it's a
> protocol violation. It could indicate that you are being called by a subsystem
> that has no business calling you.

The advice is wrong. hard_start_xmit is called even
if tbusy==1. It is legacy staff, but it is still true.
It is necessary to catch for hardware (and software) bugs,
which result in lost end of xmit interrupts.

> The tbusy flag should not be exposed to the device driver writers; it should be
> automatically set to 1 when hard_xmit returns 1 to indicate that it's rejecting

Now try to write a driver based on this statement 8)

Busy status is cleared by irq and it can (and really does on high
speed interfaces) before you returned from hard_start_xmit.

Alexey Kuznetsov
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to [EMAIL PROTECTED]

Reply via email to