On Mon, 31 May 1999, Jan Kasprzak wrote:
> jamal wrote:
> :
> : >I think there is a small bug in tc from iproute2-2.2.4-now-ss990417,
> : >which makes impossible to set the priomap parameter of the prio qdisc.
> : >The patch is as follows:
> :
> : This patch is wrong (i.e the code is fine as is).
> : By default there is a three band scheduler (pmap_mode=0). You can
> : over-ride it to have more bands by using the "priomap" construct
> : (pmap_mode=1).
>
> Nope. The patch may be wrong (depending on what the code should do),
> but the original code is wrong as well. You can add more bands by "bands"
> construct and then set the priority->band mapping by the "priomap" construct.
> In this case the pmap_mode is set to 1, and the original code overwrites the
> priomap you have just set up. Just try
>
What i am saying is: you dont need to set the bands explicitly i.e.
#
# tc qdisc add dev eth0 root handle 1: prio
#
Will set up three bands for you by default and pmap_mode will stay at 0
-- which is fine. Expected behavior.
Once you start using extra constructs like
# tc qdisc add dev eth0 root handle 1: prio bands 4 priomap 3 2 1 0
then pmap_mode is set to 1 and your priomap is set to what you specify.
I am not following what you mean by saying the original code is wrong.
cheers,
jamal
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to [EMAIL PROTECTED]
