> Removing the code prevents backward compatibility, and risks a similar
> change in the future either breaking drivers, or perhap worse, silently
> having a very bad performance impact that is difficult to trace to the
> source.
Well most of the current drivers you have break anyway if its not already
aligned Donald, and thats something I reported months ago.
Spot the problem
np = (void *)(((long)kmalloc(sizeof(*np), GFP_KERNEL) + 31) & ~31);
if(np == NULL)
goto err_out_np_failed;
dev->priv = np;
and later
kfree(dev->priv);
So all the existing drivers are not remotely back compatible anyway, they
are broken in the case of a misaligned return and have been for a long time.
Some of the other drivers 'solve' the problem by simply forgetting to free
the buffer.
Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to [EMAIL PROTECTED]
