On Tue, Dec 26, 2017 at 4:17 PM, Ross Zwisler <ross.zwis...@linux.intel.com> wrote: > On Sat, Dec 23, 2017 at 04:56:38PM -0800, Dan Williams wrote: >> In preparation for examining the busy state of dax pages in the truncate >> path, switch from sectors to pfns in the radix. >> >> Cc: Jan Kara <j...@suse.cz> >> Cc: Jeff Moyer <jmo...@redhat.com> >> Cc: Christoph Hellwig <h...@lst.de> >> Cc: Matthew Wilcox <mawil...@microsoft.com> >> Cc: Ross Zwisler <ross.zwis...@linux.intel.com> >> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> >> --- >> drivers/dax/super.c | 15 ++++++++-- >> fs/dax.c | 75 >> ++++++++++++++++++--------------------------------- >> 2 files changed, 39 insertions(+), 51 deletions(-) > <> >> @@ -688,7 +685,7 @@ static int dax_writeback_one(struct block_device *bdev, >> * compare sectors as we must not bail out due to difference in lockbit >> * or entry type. >> */ > > Can you please also fix the comment above this test so it talks about pfns > instead of sectors? > >> - if (dax_radix_sector(entry2) != dax_radix_sector(entry)) >> + if (dax_radix_pfn(entry2) != dax_radix_pfn(entry)) >> goto put_unlocked; >> if (WARN_ON_ONCE(dax_is_empty_entry(entry) || >> dax_is_zero_entry(entry))) { >> @@ -718,29 +715,11 @@ static int dax_writeback_one(struct block_device *bdev, >> * 'entry'. This allows us to flush for PMD_SIZE and not have to >> * worry about partial PMD writebacks. >> */ > > Ditto for this comment ^^^ >
Sure, will do. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm