> >> > >> This seems to needlessly tie ndctl to systemd, it should be able to > >> operate without requiring systemd. I expect it would be > >> straightforward to copy the configuration file implementation from git. > > > > Would you like to explain why it should be able to operate without requiring > systemd? > > systemd is not universally available in all distributions and it is useful to > have custom > configuration files for manually started daemons. > > Another consideration is that a sub-set of monitoring activities can be done > without > root privileges. It would be unforunate if a user could not specify changes > to the > configuration because those files are root-only and owned by systemd. > > > The reason we want to add the configuration file is that when starting > > the monitors by systemd, options and arguments cannot be passed by systemd. > > When we start monitors by using "# ndctl monitor" command, we do not > > need any configuration files, because options and arguments can be added > directly. > > > > Furthermore, if we choose configuration file implementation, we may > > encounter > the following problem. > > If we start the monitor with command like "# ndctl monitor --dimm > > nmem1 --daemon --conf-file /etc/ndctl.conf", when the variable of dimm > > in configuration file is not the same as the argument of [--dimm] option, > > which > argument should the filter_dimm() refer to? > > The command line option should union with the configuration file for > filtering options. > I.e. if the config file says to monitor nmem0 and the command line says to > monitor > nmem1 then the tool should monitor both. If there are other settings the > might be > in conflict then command line should override the configuration file. > > This matches the policy of most daemons that I have encountered in Linux.
OK, I see. Thank you very much. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
