> -----Original Message-----
> From: Dan Williams [mailto:dan.j.willi...@intel.com]
> Sent: Thursday, April 19, 2018 11:10 AM
> To: Qi, Fuli/斉 福利 <qi.f...@jp.fujitsu.com>
> Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
> Subject: Re: [PATCH 1/2] ndctl, util: add OPT_STRING_LIST to parse_option
>
> On Wed, Apr 18, 2018 at 7:06 PM, Qi, Fuli <qi.f...@jp.fujitsu.com> wrote:
> >> > Thank you very much, I made a v2 patch by referring to your sample patch.
> >> >
> >> > Going back to the OPT_STRING_LIST, I think it is necessary for ndctl.
> >> > Because the other options in monitor like --dimm-event, --bus-event
> >> > also need to support multiple space-separated arguments, these options
> >> > should be made as a string_list.
> >>
> >> Ok, yes, lets bring in string_list for that case.
> >>
> >
> > Could you merge the OPT_STRING_LIST first?
>
> Oh, I was assuming when you said string_list that you would redo the
> patch to bring in the struct string_list implementation from git, and
> not use the strtok() approach. I'd like to not diverge from that
> implementation.
>
Ok, I see. I will redo the patch to bring in the struct string_list from git.
Thank you.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
